Mr_J_Soda I'm sorry, but I don't know how to create functions for Config lib. When I learn, I'll work on some of these ideas.

I know you added full compatibility with the Primitive Survival mod, which is wonderful, but would it be possible to get some kind of config setting so we can pick if we want floating fish or Primitive Survival fish?

Hydromancerx I'm trying to learn how to mod animals and do something interesting with them; I don't know if I can do it yet. 🥵🙏

Please make more types of fish! Espeically freshwater fish!

General_JOE I'd love to do it! But I need to learn how to create entities (and make some simple 3D models) before I can make anything interesting :(

Any chance for new freshwater species in the future? It's so barren with just salmon swimming around the lakes and rivers :)

Nice!

RiverTheSheep After collaborating with the author of Primitive Survival, we've successfully resolved the item duplication between our mods. Primitive Survival and Floating Fish are now fully compatible and work together correctly :)

Ahhh, I see. Appreciate the answer! 

RiverTheSheep Yes, the mod works correctly alongside Primitive Survival. The issue is that when you use a fishing spear or catch fish in a trap, it generates a different type of 'dead fish' than the one found in FloatingFish, with different characteristics. (The Primitive Survival fish can be cooked, yields different amounts of meat when butchered, etc.). Using them together doesn't cause incompatibilities, but there are duplicate items (fish) with different values/properties.

I'm not sure if I can patch this to combine the fish items.

The problem is the Primitive Survival fish disappears when it hits the water, so I can't make it float like the FloatingFish item.

The PS fish has many more functions than mine, and I don't know how to change its 'disappearing' behavior to let it float.

Does this mod work with Primitive Survival? Or would it cause issues

I'm very sorry for the delay.

I have corrected the English translation so that it is no longer broken, and I have corrected some translations into other languages to match the official translations (others are just Google translations because I don't know the languages, but I will correct them as the official translations are updated).

Sindanarmo This mod modifies freshwater salmon (the legacy salmon) and replaces it with the new salmon. Perhaps that's why you only see that fish, because the rest of the fish are vanilla, and the biomes are altering their spawn rate.

I have exactly same bug, which was already mentioned before - after installing mod there was only one fish - salmon. It is even worse because after removing mod there is still only salmon. Installed it on 1.21.1 version of game. What I'm supposed to do to have all of the fish in my world?

Razgriz Actually it looks like the issue is caused by both the missing end comma and the '//' comments in each new section line. I checked a few other JSON files and they dont have them. Chucked the EN.JSON into https://jsonlint.com/ and it says the comments invalidate the JSON and the missing commas cause runover of the record.

Removing all //comments should resolve the issue and adding the missing commas and make the file valid again.

edited...

Yep.. it was definately user error on my part... i had the wrong version of the mod installed... all better now.. thanks 

Greetings... 
I am fairly certain that this is user error on my part... but the fish never actually float for me... 1.21 or 1.21.1 ... it doesnt crash anything, but the fish sink and stay down... ??????? 

Thanks in advance

Razgriz Ha I came here to say exactly what you did, you beat me to it! Easy fix in the .zip but yeah should be updated.

Found another minor issue with the en.lang json (it probably exists in the other lang files as well)

It's missing the entity name entry so the fish in game show up as "item-creature-fish-freshwater-salmon-pink-adult-male"

Adding these lines will fix it:

Not sure if you've been made aware or not, but you have errors with regards to your en.json lang file, which is causing some errors.

Specifically lines:

35

48

108

129

135

(the end of each fish grouping it seems)

You're just missing end line commas is all, so its a super simple fix!

I'm... not using this mod (you can guess why, someone already mentioned the reason) but I'm getting fish errors in my 1.21 stable logs. This is the only place I see mentioning them.

25.8.2025 16:22:53 [Warning] An entity fish-saltwater-amberjack-yellowtail-adult-female failed to complete initialisation, will not be physics ticked.
25.8.2025 16:23:31 [Warning] An entity fish-saltwater-haddock-common-adult-female failed to complete initialisation, will not be physics ticked.
25.8.2025 16:24:20 [Warning] An entity fish-saltwater-mackerel-atlantic-adult-female failed to complete initialisation, will not be physics ticked.

Are these fish supposed to be vanilla?

Jhoulana This is something I've thought about so many times!

But unfortunately, I don't understand ANYTHING about the 'Butchering' mod's code to add fish or other shark mods to the butchering mechanic... I'm afraid it's just way over my head :(

Mrozak bro, this isn't Twitter, idc about your personal perspective on AI stuff 🤷‍♂️

I'm not trying to do anything more than offer something to the community. I added the whole 'vibecoding' thing precisely so I wouldn't be judged too harshly for code errors and so people understand that I'm not an experienced modder.

Sorry if you hate that. I'm doing my best, if you don't like how I do it. Bye.

Thanks this should make an island play through easier.

@Reverhaus

could i request making them bucherable? i mean able to place the dead fish on the ground and harvest them ?

CaptainOats is not intersted in including fish is his Butchering mod and the thing with the fishes irks my immersive needs >.<

I dont understand why I couldnt see any fishes besides basic Salmon in lakes nor in Creative Mode Inventory itself. 

Reverhaus No need to be upset.
Yes, i HATE "vibe coding", and i strongly believe that people would get better results if they'd learned how to do stuff themselves.
Fact is, "vibe coding" is just another term for "no idea what am i doing, but proud of it" :)
This is not personal, i don't hate you, you are great, i just hate "vibecoding" - and you should too :)

Mrozak Wow! I appreciate the report, but you could be more polite and respectful next time. If you don't like a mod, you don't have to download it.

I'll get to work on it, but I hope I don't read you here again.

en.json contains multiple errors - missing commas.
i recommend you stop wasting time with "vibe coding" and do it properly.

That's amazing, thanks so much for this <3

Hydromancerx I though the fish names were on the new patch notes but they don't appear in it 🥴

This is the list of all fish (I will put in the Mod description too):

Verlia Yes! When you kill a fish, you can put it in your inventory just like any other item.

Thank you for this, I was glad to see something like it. Is there a way to pick up fish bodies/put them into inventory by chance?

What are the 29 new fish species?

Reverhaus
That would be cool! As well as support up to version 1.20.12 thank you!

Mrozak fixed! Thanks for the log 🤠

Using the mod version 1.1.0 in game version 1.21.0-rc.2 i get the following error when generating a new world:

Can be fixed by editing the disable-vanilla-salmon-pink.json as the error message suggests.

B0YAR Damn! It could be cool! Now I know a lot more about patch moar entities! I try it with those mods soon 🤠👌

Cool mod! 
Please add support for this mods
1. NA Catfish
2. NA Darters
3. NA Salamanders
4. FOTW Reqiuem Sharks
5. Something in the Water

Thank you!

ManChrzan I really like that idea! Especially with the new version 1.21.0-rc.2 which greatly improves fish and the randomized fish drops! But I'm not sure I know how to get the necessary resources to "extrapolate" that basket trap functionality and turn it into a feature to drop a fish corpse. If anyone knows how to do it, I'm completely open to it.

I really love this mod, fish sinking into the bottom of the waters was so annoyng that I couldn't bother killing them unless I was starving.
I have a suggestion though, could you make it so you can place the fish from your inventory onto the ground and then be able to harvest it like normal as an alternative to the crafting grid?

PS. I haven't tried modding VS yet, but I did other games. If I was to do it I'd look into the basket traps as a reference, since they can spawn dead animals. Hope, this helps. :D

aw. ok thanks

AgentOfChaos Wilderlands Ethology does this function already

wilderlands euthology patch?

Tasshroom33 From what I understand, Claude Opus has very limited free tokens (for everything I need to contextualize about VS modding and corrections...)

If your going to vibe code Claude 4 Opus is pretty good.

Narg Thanks for the suggestion! I have been arguing with ChatGPT for a while to help me make a patch and now the mod is compatible with BREEDABLEFISH 🤠

Reverhaus

I know you said you dont know how to patch in fish mobs, but any chance of taking a look at Breedable Fish?

Gizo
i meant this: ModsUpdate

@Gizo VS Launcher can tell you if your mods are out dated etc and other featuresl like multiple game version and installs.

automatic mod updater?!?!

Yskar - I take note of this, I had no idea! ^^U

👍 good mod

thanks! I think the vanilla fishing system is annoying and unrealistic, which makes nobody want to fish anymore once they have some food. BavarianViking

yes, more realism. thx