This is a wonderful idea and a great mod.
I am grateful that this mod exists but, it seems too much to have torches become eternal so early in the game & makes metal torch holders obsolete.
Can you add a multipler to this so that torches last twice, thrice or even 4 times as long? It would make it fit in better with the more torch holder mod or even vanilla. 

Teir 1 - Basic torch (48 hours)

Teir 2 - Wooden torch holder (96/144/192 hours or eternal - default = 96?)

Teir 3 - Metal torch holder

Please make an alterative shape that resembled a tiki torch when placed on fence posts. having 4 legs looks wrong when on fences.Thanks!

El_Neuman Added the russian translation, thank you for doing that!

Also no problem I am glad you and so many others are enjoying it so much!

Here's updated russian translation! Thanks for amazing mod))

Kaw hahah so honestly I never even thought to include this as a thing because I didnt think people would use it that way, so I would say not a feature or bug just not implemented.

Was there a specific reason you were trying to do this or were you just randomly trying to do it? I can see about putting it in if you needed it for like aesthetics or something but it would probably require some work on my end overall that I would need a good reason to do =p

I thought it was broken but it turns out you just can't place unlit torches in the holder. I'm not sure if this is intended but in case anyone else sees this comment, just light the torch and try placing it again and that worked for me.

McDarki24

I am about to upload the 1.21 compiled version here shortly.

Hey we currently have a world with this mod should we wait with updating or what would happen with the torches?

XyrVexus

Sure, shoot me a message on discord and I will reply back in the morning to go over what this would require. As long as its not going to effect the mod itself or anything then I dont see why not.

Hey there, awesome mod! Would you be willing to add json patches for integrating with Real Smoke? I've examples on my modpage, or I can provide exactly the patches you'd need on Discord

Mynxae Hahah I actually forgot to adjust the value of the light given off by the wooden torch holders to the new value added in 1.20.

I will adjust them to the new new value given in 1.21 (light levels are getting nerfed a bit in 1.21).

Thank you for pointing this out though, completely slipped my mind!

Question - why is it that when torches are placed in the wooden torch holders, their light radius decreases compared to a torch just put onto a block manually? 

Hmmm interesting, I will have to look into that. It probably happened when I tried to make it so they couldn't be placed on surfaces they shouldn't be able to (broken surfaces)

Kaeviel

Hi, I really do like this mod - but do the torches not attach to chiseled blocks? I've taken a hammer and chisel made sure all my blocks in my cellars are insulated, but then when I try to place the torch holders, nothing happens.

So far thats 3 unusual bugs I passed on. Not that I'm counting ;-)

Interesting bug hahah, I will take a look at it and see if I can put in a method to stop that type of situation from occuring! Might take me a little though, got lots of stuff going on right now =p

Also thank you for breaking down how to replicate it, actually very helpful with coming up with a solution!

DilanRona

Fixed now

Picked up a bug with the wooden torch holder. when placing a toolrack on the wall, and a wooden torch holder next to it. When clicking on the side of the torch holder, it deletes the toolrack (and everything on it) and replaces it with the wooden torch holder. Breaking the torch holder results in only the torch holder being returned and the toolrack is sent to the void.

Using VS 1.20.9, with NDL Wooden Torch holder 1.4.1.

Hi, didn't update the mod, but got the latest update of the game (1.20.8) and... now it works?

Not sure if it had to do with me playing on a server last week and now singleplayer tho.

All good, I will look around but I haven't had an issue on my end or any other reports.

I'd just have to ask if your using the latest version of the mod (v1.4.1) as I did do a bit of an overhual there.

Also could you try it in a fresh new world with only this mod active and let me know if the issue persist?

valrossenOliver

Sorry, was away on Easter.

Seems to be on all holders (wall, roof, floow). No errors in log.

Game version 1.20.7

Wall example here:

https://imgur.com/a/9cGdMSy

Sounds like a graphical glitch.

Can you somehow link me a screenshot of the issue?
Is it replicatable?
Does it happen to all the torch holders you place or just specific ones?
Version of Mod and Version of Game?

valrossenOliver

Not sure if just OAK torch holders but the ones I crafted are pitch black like coal. Graphical glitch or is oak supposed to be charcoaled?

My castle's gonna be lit!

Ok, so I put some thought into it and laid out how it would probably need to be done (and done right). I currently started another mod project thats gonna take a bit of time but I will probably swing around to your idea here once I get that one up and running.

Key points
- It will be a config option that will be OFF by default.
- It will replace the torch with a extinguished torch, not just clear the torch out

I can't PROMISE I will go through with the idea, but its on my notepad for this mod =p
Stroomschok

I mostly want the feature because of the functionality. Infinite lightsources kinda bug me :P

Just having the model at least revert to the empty holder when the torch runs out would already be a big improvement for my taste.

NateDoesLife

I will consider it but more unlikely then likely.

It would be a fair bit of work on my end for a feature that already exists in the game
     - New extingished models
     - Adding the functionality for this to the models
     - Build a config and integrate it to the mod

Do you want this request specifically for the models?

Stroomschok

Would you be able to make a version that where the torch does run out? 😍

Will take a look! Thank you for pointing it out!

Eldritch_Warrior

hey, noticed a small texture glitch on the ground torch holder on the inside of one of the legs, you can see it in the crafting window output image as well as when its placed, not to crazy or anything but thought id mention it since i noticed it right off the hop when making them

Thanks bro! aprechiate this one. Now I can get the apmisphere right in my castle without buring though tuns of metal.

Huh lol, I will look into that one asap! Thank you for reporting it!

DilanRona

Found an obscure bug. When all your handbasket slots, inven slots (1-10), and the offhand contains anything other than a torch, when you right click the wooden torch holder that contains a torch, the torch doesnt drop to the floor as expected with the brass torch holder, but instead dissapears into the void.

I actually tested this during the creation of the mod, and it didn't seem so during that time but hey if they happen to catch fire let me know and I will look into it.

IILordTempestII

I wonder if the torch holders can be set on fire themselves... are they burnable if attached to a block that is then set on fire?

Thank you very much, I just had to do a quick update to the mod though to adjust the light level and color to properly match torches.

PastaNipples

Incredible, and the mention of possible standing torch holders? chefs kiss

Much appreciated for the hard work!