Mods / Chiseled Block Retention
Author: Rythillian
Side: Both
Created: Jun 21st at 5:04 PM
Last modified: Nov 24th at 6:43 AM
Downloads: 40392
Follow Unfollow 578
Recommended download (for Vintage Story 1.21.5):
ChiseledBlockRetention-2.0.0.zip
1-click install
As of version 2.0.0 of this mod it changes all faces but UP to always be true for chiseled blocks. This has the same affect as the previous version but fixes visual bugs and compatibility with other mods.
This means that the rules for chiseled blocks being solid or not (which determines if they will allow a room to be detected as a room) will be ignored. The block should always be counted as solid now! This affects cellars, rooms and greenhouses (so all room types). So if you've ever been annoyed that your beautifully chiseled room is not detected as a "room" (probably because you made custom chiseled windows) then this mod is for you! And yes you can still waterlog chiseled blocks.
What this mod doesn't change: This mod does NOT change the collider for the block; you can still shoot projectiles through the holes in your chiseled block, you can still attach or click through the holes in your chiseled block, you can still waterlog chiseled blocks, chimney's will still detect firepits and produce smoke through chiseled blocks, and finally placing objects on chiseled blocks works still, all of these still follows vanilla rules! This mod ONLY affects room detection. This mod was made for my server to go along with another mod that makes mechanical objects solid, you can find that here!
This mod should be safe to add and remove, but with that said there may be conflicts with other mods that affect the chiseled json (though I don't know of any), and there is a chance for some rooms to now be detected weirdly. But from my testing it seems to work fine, lemme know of any issues you find!
chisel
chiseled
chiseling
chiseled blocks
chiseled block retention
chiseled rooms
chisel room
room detection
room retention
heat retention
solid blocks
always solid
side solid
room
rooms
| Mod Version | Mod Identifier | For Game version | Downloads | Released | Changelog | Download | 1-click mod install* |
|---|---|---|---|---|---|---|---|
| 2.0.0 | cbr | 4861 | Nov 24th at 6:15 AM | ChiseledBlockRetention-2.0.0.zip | 1-click install | ||
|
Long awaited snow visual bug fix and possible realsmoke compatibility update. And guess what, it turns out the fix was incredibly easy lol. Changes:
| |||||||
| 1.0.0 | cbr | 35531 | Jun 21st at 5:42 PM | ChiseledBlockRetention-1.0.0.zip | 1-click install | ||
|
First release of chiseled block rentention. Simply sets "sidesolid:" to always be true for Chiseledblock.json, chiseledblock-snowcovered.json, microblock.json and microblock-snowcovered.json. | |||||||
Thank you for adressing the issue, will test it today, youre amazing!
Nachi Thanks for getting back to me, yeah if the crash log is about crickets then there's no way it's this mod lol. Though the idea that the crickets hate the idea of chiseling rooms is a funnny one.
Rythillian I switched back to version 1.0.0 and am no longer having the issue, despite playing for several hours. Though I'm not sure what else it would be having issues with, since none of the others are supposed to impact particles or rooms. I'm willing to experiment, though. I will try switching back to v2.0.0 and disabling one mod at a time, I suppose.
Edit: I started reading the crash log again, in case I was missing something, and it seems to be something regarding the crickets, not the rooms/particles (which means it's probably not connected to this mod, but rather where the crickets were. Sorry to bother you.
Rythillian Yeah that answers so many things, it looks like the 'me misunderstanding the issue' thing was applicable for both of the bugs lol. How embarassing.
Either way, I am extremely grateful for the clarity that you've provided, and should be able to return to making lidded chimneys in peace.
Nachi Hmm I haven't been able to recreate this issue. You appear to be using a lot of other mods and I don't really see why this mod would suddenly cause particle plus to crash. If it happens again see if you can consisently reproduce it AND then see if it occurs with JUST particle plus and this mod (that way I can reproduce it myself to fix it if it's this mod causing the issue). The same is true for the other mods, as if there is a conflict with one of them you'll have to report it to the dev for the other mods. Do lemme know if there's any updates on this!
@lupiter
Heya thanks for the writeup. The incompatibility was that if you created a 1x1 chiseled chimney (so 1 block that had a hole chiseled through it), the real smoke mod would still see the block as being solid. The dev wrote "The chimney is valid only if blocks below the chimney are not entirely solid. To that end i use block.sidesolid.all". Because this mod made all chiseled blocks "sidesolid.all" it made it incompatible. The solution was just to make all sides but UP solid. This has the same effect as the block being solid for room detection as the bottom of the block will still be solid and because the game checks both sides of a face for room detection, it marks the room as valid while still allowing the block to have proper passthrough for real smoke!
This was a very easy fix and one that I had in mind for a long while now, but I have been unable to find the time to do it sadly. And when I did do it, it only took at most an hour to make sure everything was working as intended. This mod is actually incredibly simple, there isn't really any "code". It's all just a json patch that changes a couple lines in the json files for chiseled and microblocks (though I might remove the microblock patches as I think they might actually not matter). I've done some further playtesting and haven't noticed any differences between room detection with both versions. So 2.0.0 should just be an improved fixed version of 1.0.0. With that said there is the possibility that there is some odd case where room detection is not proper with this change or perhaps where sound is allowed to passthrough but I have yet to find it. I've also been meaning to see what happens if this mod is made completely server side, I remember testing it awhile back and getting mixed results, specifically with clientside hud mods not detecting rooms correctly.
As for the snow issue, the issue you are currently seeing with 2.0.0 still is indeed vanilla. There isn't anything I can do to fix that as it's not related to the mod itself. But there actually is a fix for it but you have to go into your gpu drivers and change some settings. I think specifically "anisotropic filtering" is the setting to disable specifically for VS. The same issue actually crops up in minecraft all the time as well, you can find more info on this by searching "lines between blocks" or "gaps between blocks" online. I never end up bothering to do it tbh because nvidia likes to reset my settings and I can't be bothered.
For some info on the snow issue that was fixed, there WAS an issue caused by this mod where some complex chiseled items would have a layer of snow put on air. Where voxels that were air and thus shouldn't have snow, would have snow. This was most common on overhangs or trader carts. Infact trader carts are what I used to test the issue since they would pretty much always have the issue. I tested switching back n forth between 1.0.0 and 2.0.0 and the glitch would disappear on 2.0.0 everytime. So thankfully people were not gaslighting me lmao. I host a lot of game servers in my spare time so I had plenty of reports from my VS servers about this issue to where I was easily able to find lots of examples to test and mess around with. Anyway I hope that answers any questions and I appreciate the detailed comment!
Not certain if it's this mod, but I had no issue before the v2.0.0 update and now I'm crashing occasionally. The most recent crash came with a log file that mentions rooms, but also mentions particles, so I'm wondering if something in the update went wrong and/or is incompatible with Particles Plus. Weird thing is that I have not even obtained a chisel yet in this new, singleplayer world. I'm gonna try testing this by running it with the previous version, without Particles Plus, without this mod, etc.
Out of curiosity, I went back and used version 1.0.0 with the RealSmoke mod to check out what the incompatibility was, but I can't really seem to find it...? I wasn't getting any errors, and the chimney was letting smoke out of a room just fine in both versions. Neither was I able to find any changes in snow effects when comparing vanilla, 1.0.0 the version of this mod, and the 2.0.0 version of this mod, with no other mods active. (the snowcover on the chisel blocks all looks a bit weird, but I think it's very easilly attributable to a vanilla bug/design decision since they all look weird in the exact same way. None of them felt like they had hovering snow either) I did try to make sure by going back to 1.20 (the unofficial VS launcher was unexpectedly simple to use for this purpose) and see if it was a bug specific to that version of Vintage Story, but alas, other than the incredibly amusing sight of the moon rising from the west, I was still not able to see any visual differences, especially in snowcovered, chiseled blocks, whether this mod was on or not.
While I'm rather tempted to say that genuine playtesting reliability and the identification method of issues are a bit lacking in the community as of now (admittedly it consumes an awful lot of time in an increasingly accelerating world), it could also just be that unknown, different variables are causing different issues for everyone (such as emergent behavior due to multiple mods interacting with each other, the state of the operating system, the state of the machine, etc) and/or updates to the base game have inadvertently affected/solved past bugs that may or may not have been caused by mods as well. It's also entirely possible that I've completely misunderstood the issue that was discussed previously by other commenters, and am only barking up a completely wrong tree. In any case, I conclude that the current version does show intended, debugged behavior, and also only hope that we did not collectively gaslight a (until recently) bedridden coder into squashing bugs that did not even exist in the first place out of sheer paranoia.
I like this mod quite a bit, by the way. Lets you make some really interesting entrances and exits and access points.
XyrVexus and LastHazzerd, I have put out an update to the mod that is incredibly simple. It just changes one of the faces (the top) to not be solid. This fixes the issue with both snow and hopefully also with the realsmoke mod (from what I tested it did work but I haven't used the mod before now). I haven't noticed any issues with changing just the top to be non solid, the bottom remains solid and oddly this means that all the rooms I've tested remain as rooms lol. This also had the odd effect of making vanilla chimney's also work to display smoke. Lemme know if this causes any issues or if there's been any updates on your potential rework of the room detection system. Wanted to do this ages ago but sadly life got in the way.
Got the bug fixed and will be uploading a fixed version tonight. Just testing to see if I can also fix the incompatibility with the "Real Smoke" mod as well!
Is there a way to disable this effect for specific chiseled blocks, such as for a chimney?
JaneDaPixelPixie You can just remove the mod if the bug occurs, it's not permanent (also purely visual). It'll also go away with snow melting as well! I haven't gotten the chance to fix it as of late (been very sick), but should have something soon hopefully.
any updates on that snow layer bug? im interested in this mod, but since the whole point is to have a more pretty house, im a bit hesitant to download it when theres a visual bug like that
Would it be possible to remove the snow layer from chiseled blocks to get rid of that visual bug?
GLaDOS_cz Yeah it's a visual bug atm that I'm hoping to find a solution for. But don't worry, it's purely visual and will go away when the snow melts as normal. I may have a fix posted soon though. Weirdly it doesn't always happen, which is odd to me.
Omg, love this mod, is a diamond for builders!
When its winter and snow, some chiseled blocks have levitating layer of snow at ground level of the block. I suspect its caused by this mod?
I have a one voxxel thick wall of glass for a roof/wall. downloaded this mod but im still showing not a room with /debug rooms hi
Rythillian
Per XyrVexus's comment, I am looking into reworking the Room detection of the game, not by changing what the game consideres heat retaining or chissled and such, but adding different room types with different effects.
Consequently the search will count chissled blocks, and blocks like slabs, fences, and stairs as actual walls, but it won't count the room it makes as an 'enclosed' room, so the effects on whats inside the room won't be the same.
But it will only check if a block is chissled/stairs/slabs/fences, etc, if it first determines the block it runs into does not have any heat retention.
Everything is still WIP and I'm trying to get it so that the flat side of stairs do count as solid walls, right now I don't believe they do.
jimbobalinsky Hmm you should be able to place items on chiseled walls just fine, I know I certainly can. It should be noted the block being "full" doesn't always mean you can place something on the wall. It's only used for room detection and NOT the collider. This mod should not affect that as I've mentioned in another comment. Instead try messing around with the face you are trying to attach to as it's possible it might not be large enough for whatever you are attaching. I know for some objects too the size of the face weirdly changes with rotation??? Like I have no idea why it does that lol. Send a screenshot sometime!
XyrVexus Ah yeah that is is unfortunate. I have been experimenting with fixing the snow problem by making it so the TOP is not solid, but the bottom is solid. Which may fix that issue as well? We'll have to see.
As for the other approach, I totally agree! A full rework of the room detection system would be the best option, but atm this is tricky to code and would take substantial time. That's why I threw together this json mod, it was made to be quick and light. As this mod can be added or removed easily whenever. With that said I highly reccomend someone with the time and knowhow to look into making a proper room detection overhaul as it would be incredible.
Rythillian Nyarc hey I just stumbled upon CBR. I went ahead and did some testing and confirmed this would cause issues with Real Smoke's chimney detection. If even one side were non-solid, the chimney detection would work. I imagine it could cause other unintended side effects in the game / other mods. Because of that I would recommend a different approach - change the room detection rather than marking all chiseled blocks as all-solid. But that's a lot of work. Pretty sure LastHazzerd is looking into something along those lines, maybe a collaboration opportunity?
I'm currently unable to place items on chiseled walls despite having downloaded the mod and made sure that it's activated in my game. Is there something I'm missing?
Nyarc I haven't played with realsmoke so I'm not sure, I do plan on checking it out but you may beat me to it. If you do play with realsmoke I'd reccomend testing it with this in creative first!
MRGOOSE This is incorrect! Hitboxes for the blocks are not bassed on the "Full" status in the json. I've attached an image of a block I chiseled where I fired both an arrow and a spear through it. It is likely either the hitbox of whatever you are shooting is larger than the hole or another mod is causing the issue.


Tested this also on an even smaller hole and it still works (Little hard to see at this angle but I swear thats an arrow onthe wall by my crosshair):
Realsmoke Compatability?
it seems like this mod also prevents shooting through gaps in chisled blocks.
smt923 Greenhouses should work! I make complex chiseled greenhouses all the time with the mod. BUT make sure you are still following the room rules. This mod only changes how chiseled blocks are made solid, not room sizes. For larger room sizes check out something like this (note I have no idea if it works in latest verison but it's worth a try) -> https://news.kalataka.ru/show/mod/26102
Besides the room size stuff the only other thing I can think of is you have some other block besides a chiseled block that is counted as not full.
does this also change or affect the rules for chiselled glass for greenhouses? we're struggling to get one to register as a valid greenhouse even with this mod :(
ShikiTochi Hmm not sure, I'd have to see if there's a json setting to mark it as unsafe for mobs. Mobs ignore full blocks, and this changes them to be full blocks, so it would need some sort of alt. One thing I have been messing around with is potentially making all sides except for the TOP to be full. Which might fix the snow issue as well.
Would there possibly be a way to keep the chisled blocks as unspawnable blocks for mobs, I love what the mod does but because of how its done it allows mobs to spawn on chisled blocks again.
Rythillian hopefully the chiseling will get reworked at some time. For now like always I resort to mods.
ChiefKrogan I absolutely agree! If I was to make any changes to the base game room system again I would honestly just get rid of the 50% rule. Basically the game checks if 50% or more of voxels remain, if there is at least one solid face across one side and if a block is flush with another. IDEALLY we'd want a fix that just checks each face of the block with some sort of "flood fill" algorithm and determines which sides of the block should be marked as "full". The game already supports specific face "full" settings. But we'd need that "flood fill" thing to actually determine the solid faces of a block.. AND in a way that doesn't ruin performance... perhaps having it only be done when a chiseled block is updated. If we had that then we could just straight up get rid of ALL the old rules.
MRGOOSE I sadly couldn't find any fixes for that. I'm still of course wanting to fix it, but with the json as is there doesn't appear to be a way... of course if someone does find a fix they are welcome to contact me and I would absolutely update the mod with the fix.
can you please find a fix for the snow visual bug? it can be a seperate mod to keep this one lightweight
I wish the base game had something in between what it currently has and this mod. The room being so blatantly open as in the third screen should absolutely not retain heat, but the current base game option is frustraiting beyond belief. What's the point of being able to chisel if it makes me freeze in winter?
I will go with this mod, thank you for your work.
thank you for keeping the chisel community alive!
LunaGore Yes this should be working in the latest version! The only issue this mod has atm is that snow can sometimes look a tad glitchy on some blocks, but I've been unable to find a simple fix for this that doesn't involve making this mod heavier than the simple json it currently is. But seeing as this is a minor visual glitch, most folks don't seem to mind.
Guimoute Heya, just to clarify some of these things absolutely are bugs lol. But yes other things are technically working as intended, though that intention is very flawed. Also just for transparency, I was on the dev team for a short while and did attempt to make some fixes to this chiseled room detection system but it was not enough to fix all the issues with it! And since I was supposed to be mainly just working on sound design I really couldn't just dedicate all my time to it other than it just being "good enough"; and fixing any issues that the new sound stuff we were working on introduced with it. It honestly just needs a complete overhaul one day... but alas it's just not that high priority compared to other things!
Rythillian I don't know if it helps them when we report just things as bugs. It's not a bug in that their system works at intended, they just did not intend enough. It's more of a complaint about completeness if you know what I mean.
Tested with greenhouse on new singleplayer on 1.21 and it did validate as a greenhouse with chseled holes
Does this work on 1.21?
Just in case anyone was here for the same reason as me, this mod also stops rain sounds from leaking through chiseled blocks.
Guimoute Yeah It's very unfortunate. Alas I am no longer on the VS team in order to report such an issue. So I request that folks go report it on the git and make a stink of it :P (joking, but you should report that!)
Ourcasula There is an oversight in vanilla in addition to what you mentioned. The room calculations look at solid faces at the edges of a block, that means you can close a room without problem with vertical slabs for example, because there is always a valid face hugging the outside boundary or inside boundary. Now if you chisel that slab so that it's centered, it still completely closes the room (visually) but the game does not recognize it, which sucks because sometimes I just want my vanilla glass panes supported by a centered slab and not a full block.
Ourcasula Oh I know of that bug! I've reported it before in the past. Sad to see it's still around..
Rythillian I figured out what it was; there's not an issue with the chiseled block retention, there's an issue with copies from chisel tools. You just need to update the copies by chiseling a voxel manually to fix it. So there's no issue with your mod in this instance.
Thanks for trying to recreate it!
Fadek The command is /debug rooms hi, you can do debug rooms unhi to disable it!
Ourcasula Tried to recreate your basin issue and have been unable to find any issues. Are you sure you are meeting the requirements for the block to be filled with water?
How you make this green " box" where room is? Is shortcut for IT or its a mod?
Ourcasula Hmm odd we've been able to create basins on my server, use them for sinks n stuff. I'll have to see if perhaps it's broken. I know that snow buildup can be visually buggy with the mod but I think I might have a fix for that. But I'm looking into making a non json mod to maybe get around all these issues entirely.
I'm having issues with making basins out of chiseled blocks, though; I remove more than 50% of the cube but since all the sides are technically full insulation sides it might be causing issues with waterlogging chiseled blocks. Let me know if maybe I'm missing something, though
Autumn Ah yeah we started to notice this as well on my server. Not sure how best to go about fixing this as it appears the solid status of a block apparently affects how the snow is generated on the faces. Which is a bit odd. I'll mess around and see if there's a fix unless someone unless finds a fix first and lets me know! Thankfully it's purely visual so we'll still be using the mod since we prefer staying warm lol.
Love what this mod does, can finally have chimney's that aren't all weird to retain a room's "room" status, though there is one downside to this mod, that happens when winter hits... That aside though. <3
TotallyNotASmurf Yup! It'll consider it as if the chiseled block was full, so you could technically make a block with 1 voxel and the game would still think of it as solid. Which is what the vanilla rules try to prevent, but I find them to be too restrictive.
Mateo_Matthew It's possible you just needed to reload the world/mod list for it to take affect on already placed blocks. We use it on my server which restarts often, so on first install we probably wouldn't of noticed if blocks didn't immediately update.
Rythillian Not exactly sure what fixed it but I removed it from my mods and when I added it back everything was working as described. Appologiez, thanks for the awesome mod.
THANK YOU I LOVE YOU
Wait, so with this mod even a chiseled doorway now counts as a room? Oh my god I can finally not have doors in my house without it messing with my cellar.
Mateo_Matthew Without seeing a screenshot I'm unable to tell if it's specifically an issue with chiseled blocks or if perhaps another thing might be causing the room to not be detected properly. If you want you can send me a AT (cant use the symbol cause it tries to AT a player username here) in the Vintage story discord in the #mod-development channel and I'll gladly take a look! My username is the same over there.
Thanks, works great for most chisled builds. Still finding issues with buildings that have chisled blocks for the roof.
Bro, thank you! Working as intended.
Leozin It's a rather undocumented mechanic, but one that many people end up bumping up against lol
No way! I didn't even know chiseling did that, no wonder my house was always freezing
AtomikRonin Yes this should work fine on all 1.20 versions! I'll update the download to have that marked.
! Any chance this will work with 1.20.10?
I have been trying to get my interior partition walls to work with a chiseled skirting board and door frame on either side today, but to no avail, so glad you've made this, thanks.