organicoil Thanks for investigating it!
A configurable option for overwriting this vanilla behaviour would be a cool addition.
I guess for most people it doesn't matter too much, I noticed it whilst using the Hardcore Water mod (aquedcuts would still channel water from "frozen" ponds).

The_Revisionist Never noticed this myself, but the game actually considers those adjacent blocks as flowing water.

The easiest way to see this is by enabling "Liquid selectable" in creative. But you can also see it in survival - all 3 adjacent blocks will have flowing water particles (those particles are probably the reason why the game does it this way).

Meaning the blocks actually look like this:

Summer:
🟦🟦🟦
🟦🟦🔵
🟦🟦🔵🔵🔵🔵
🟦🟦🔵
🟦🟦🟦

Winter:
⬜⬜⬜
⬜⬜🔵
⬜⬜🔵🔵🔵🔵
⬜⬜🔵
⬜⬜⬜

So it does seem to be working "as expected", even though the result is somewhat silly.

I'll try adding an option to freeze such "flowing source blocks" to the mod when I have the time.

Thanks a lot for reviving this absolutely essential mod!

I have a question:
Is it normal that water source blocks adjacent (both orthogonally and diagonally) to a flowing water block don't freeze?

For example (top-down view, 🟦=liquid (lake) water, ⬜=frozen water, 🔵=flowing water, assume solid ground (e.g. soil) around the water blocks):

Summer:
🟦🟦🟦
🟦🟦🟦
🟦🟦🟦🔵🔵🔵
🟦🟦🟦
🟦🟦🟦

Winter:
⬜⬜⬜
⬜⬜🟦
⬜⬜🟦🔵🔵🔵
⬜⬜🟦
⬜⬜⬜

To be honest I never checked this behaviour in vanilla, so it might be the a vanilla mechanic and nothing to do with this mod. I thought I'd double check though.

sorry didnt mean about issues. worded that wrong and wa asking about compablity between the 2 mods since they touch the same system is all. thats what happens when you post things while brain dead from work. :(

That's should be on the base game))

Sidfu So far I'm not seeing any issues when using my mod togeher with Brain Freeze. I see that the planned features for that mod include "Redoing how water blocks freezes into ice (so it doesn't end up looking like swiss cheese)" - this is the only thing that can potentially lead to issues, but it is still unlikely (and I can't do anything about it until the mod autor actually implements it).

So unless any specific issues are reported - I don't see a need in compatibility patches.

This is awesome! frozen lakes in summer has always bothered me.

Sidfu I can try, though I don't use Brain Freeze myself so I'm not sure what can be an issue when using it together with my mod. Are you expiriencing some specific issues?

can you look into comp beftween the mod and this one.

Thanks for reviving this mod!

This is fantastic!

Samogitia That's the main idea :)

Guimoute "water-still-7" is basically lake water, as far as I've seen salt water does not freeze in the base game so the mod also does not affect it

Omg... Will this finaly fix "ice blocks in the summer" nonsense.

Very nice. I see in your code WATER_BLOCK_PATH = "water-still-7". Is salt water unable to freeze in vanilla (I have not enabled oceans in 1.20 so I don't know, I will in 1.21) or will the mod progressively turn the surface of a salt water sea into fresh water as it thaws?

Reizeron, thanks for the feedback! I'll definitely look into these two things

I was JUST working on pretty much the same kinda thing! I guess I don't need to anymore lol.
In my version I also added an "if (!GlobalConstants.MeltingFreezingEnabled) return" check, just in case somebody disabled that setting mid-game. Also the method I used was to check if yesterday's hottest/coldest temperature was lower/higher than the freezing/thawing temperature, respectively (that way you know the temperature won't be moving out of the freezing or thawing threshold for near future) It took into account the fact that drier climates have higher diurnal temperature spread than wet climates. Would be cool to see an option like that implemented here too, but the way you did it works for me too.
Thanks for the mod!